flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8458) Add the switch for keeping both the old mode and the new credit-based mode
Date Fri, 19 Jan 2018 15:38:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8458?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16332411#comment-16332411
] 

ASF GitHub Bot commented on FLINK-8458:
---------------------------------------

GitHub user zhijiangW opened a pull request:

    https://github.com/apache/flink/pull/5317

    [FLINK-8458] Add the switch for keeping both the old mode and the new credit-based mode

    ## What is the purpose of the change
    
    *After the whole feature of credit-based flow control is done, we should add a config
parameter to switch on/off the new credit-based mode. To do so, we can roll back to the old
network mode for any expected risks.*
    
    *The parameter is defined as taskmanager.network.credit-based-flow-control.enabled and
the default value is true. This switch may be removed after next release.*
    
    *This PR is based on #4552  whose commit is also included for passing travis.*
    
    ## Brief change log
    
      - *Abstract the `NetworkClientHandler` interface for different implementations in two
modes*
      - *Abstract the `NetworkSequenceViewReader` interface for different implementations
in two modes*
      - *Define the `taskmanager.network.credit-based-flow-control.enabled` in `TaskManagerOptions`*
    
    ## Verifying this change
    
    This change is already covered by existing tests*.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (no)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (no)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (no)
      - If yes, how is the feature documented? (not applicable)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhijiangW/flink FLINK-8458

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5317.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5317
    
----
commit a3b41f51173adaa382b42877142664d2b09101f7
Author: Zhijiang <wangzhijiang999@...>
Date:   2017-09-30T06:36:19Z

    [FLINK-7456][network] Implement Netty sender incoming pipeline for credit-based

commit a8154989f9c93e71e3051d7184c0f02316f1a3c7
Author: Zhijiang <wangzhijiang999@...>
Date:   2018-01-17T06:15:04Z

    [FLINK-8458] Add the switch for keeping both the old mode and the new credit-based mode

----


> Add the switch for keeping both the old mode and the new credit-based mode
> --------------------------------------------------------------------------
>
>                 Key: FLINK-8458
>                 URL: https://issues.apache.org/jira/browse/FLINK-8458
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>            Priority: Major
>             Fix For: 1.5.0
>
>
> After the whole feature of credit-based flow control is done, we should add a config
parameter to switch on/off the new credit-based mode. To do so, we can roll back to the old
network mode for any expected risks.
> The parameter is defined as {{taskmanager.network.credit-based-flow-control.enabled}} and
the default value is true. This switch may be removed after next release.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message