flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8454) Remove JobExecutionResultCache
Date Thu, 25 Jan 2018 18:22:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8454?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16339591#comment-16339591
] 

ASF GitHub Bot commented on FLINK-8454:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5311#discussion_r163923585
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
    @@ -100,8 +97,6 @@
     
     	private final LeaderElectionService leaderElectionService;
     
    -	private final JobExecutionResultCache jobExecutionResultCache = new JobExecutionResultCache();
    --- End diff --
    
    `JobExecutionResultCache` and `JobExecutionResultCacheTest`  should be also removed in
this commit


> Remove JobExecutionResultCache
> ------------------------------
>
>                 Key: FLINK-8454
>                 URL: https://issues.apache.org/jira/browse/FLINK-8454
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination, REST
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> With the introduction of the {{SerializableExecutionGraphStore}} to the {{Dispatcher}},
it is no longer necessary to store the {{JobResult}} in the {{Dispatcher}}, because all information
necessary to derive the {{JobResult}} is contained in the {{SerializableExecutionGraphStore}}.
In order to decrease complexity, I propose to remove the {{JobExecutionResultCache}}.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message