flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8449) Extend OnCompletionActions to receive AccessExecutionGraph
Date Wed, 24 Jan 2018 14:42:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8449?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337672#comment-16337672
] 

ASF GitHub Bot commented on FLINK-8449:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5308#discussion_r163544619
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/jobmaster/JobManagerRunnerMockTest.java
---
    @@ -250,19 +255,15 @@ public void testRegainLeadership() throws Exception {
     		private volatile boolean finishedByOther;
     
     		@Override
    -		public void jobFinished(JobResult result) {
    +		public void jobReachedGloballyTerminalState(ArchivedExecutionGraph executionGraph)
{
     			checkArgument(!isJobFinished(), "job finished already");
     			checkArgument(!isJobFailed(), "job failed already");
     
    -			this.result = result;
    -		}
    -
    -		@Override
    -		public void jobFailed(JobResult result) {
    -			checkArgument(!isJobFinished(), "job finished already");
    -			checkArgument(!isJobFailed(), "job failed already");
    +			this.result = JobResult.createFrom(executionGraph);
     
    -			this.failedCause = result.getSerializedThrowable().get();
    +			if (!result.isSuccess()) {
    --- End diff --
    
    Maybe 
    ```
    result.getSerializedThrowable()
    				.ifPresent(serializedThrowable -> failedCause = serializedThrowable);
    ```
    to avoid IntelliJ's inspection warning.


> Extend OnCompletionActions to receive AccessExecutionGraph
> ----------------------------------------------------------
>
>                 Key: FLINK-8449
>                 URL: https://issues.apache.org/jira/browse/FLINK-8449
>             Project: Flink
>          Issue Type: Improvement
>          Components: Distributed Coordination
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>            Priority: Major
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> The {{OnCompletionAction}} currently only receives the {{JobResult}} when the job terminates.
For further archiving of the {{ArchivedExecutionGraph}}, we should change this to {{AccessExecutionGraph}}.
The {{AccessExecutionGraph}} contains all the information to derive the {{JobResult}} and
additionally the information needed for serving information about completed jobs.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message