flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8338) Make CustomCommandLines non static in CliFrontend
Date Thu, 11 Jan 2018 12:41:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8338?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16322158#comment-16322158
] 

ASF GitHub Bot commented on FLINK-8338:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5224#discussion_r160946952
  
    --- Diff: flink-clients/src/test/java/org/apache/flink/client/cli/util/MockedCliFrontend.java
---
    @@ -20,40 +20,22 @@
     
     import org.apache.flink.client.cli.CliFrontend;
     import org.apache.flink.client.cli.CliFrontendTestUtils;
    -import org.apache.flink.client.cli.CustomCommandLine;
     import org.apache.flink.client.program.ClusterClient;
     import org.apache.flink.configuration.Configuration;
     
    -import org.apache.commons.cli.CommandLine;
    -
    -import static org.mockito.Matchers.any;
    -import static org.mockito.Matchers.anyString;
    -import static org.powermock.api.mockito.PowerMockito.mock;
    -import static org.powermock.api.mockito.PowerMockito.when;
    +import java.util.Collections;
     
     /**
      * Utility class for mocking the {@link ClusterClient} within a {@link CliFrontend}.
      *
      * <p>The mocking behavior can be defined in the constructor of the sub-class.
      */
     public class MockedCliFrontend extends CliFrontend {
    --- End diff --
    
    True. But since I didn't introduce it, I'll keep it like it is (avoiding further downstream
merge conflicts).


> Make CustomCommandLines non static in CliFrontend
> -------------------------------------------------
>
>                 Key: FLINK-8338
>                 URL: https://issues.apache.org/jira/browse/FLINK-8338
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> For better testability and maintainability we should make the {{CustomCommandLine}} registration
non-static in {{CliFrontend}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message