flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8332) Move dispose savepoint into ClusterClient
Date Tue, 02 Jan 2018 15:36:04 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8332?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16308243#comment-16308243
] 

ASF GitHub Bot commented on FLINK-8332:
---------------------------------------

Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5219#discussion_r159249258
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/CliFrontend.java ---
    @@ -659,128 +655,107 @@ protected int savepoint(String[] args) {
     			return 0;
     		}
     
    -		if (options.isDispose()) {
    -			// Discard
    -			return disposeSavepoint(options);
    -		} else {
    -			// Trigger
    -			String[] cleanedArgs = options.getArgs();
    -			JobID jobId;
    +		CustomCommandLine<?> customCommandLine = getActiveCustomCommandLine(options.getCommandLine());
     
    -			if (cleanedArgs.length >= 1) {
    -				String jobIdString = cleanedArgs[0];
    -				try {
    -					jobId = new JobID(StringUtils.hexStringToByte(jobIdString));
    -				} catch (Exception e) {
    -					return handleArgException(new IllegalArgumentException(
    -							"Error: The value for the Job ID is not a valid ID."));
    -				}
    +		ClusterClient clusterClient = customCommandLine.retrieveCluster(options.getCommandLine(),
config, configurationDirectory);
    +
    +		try {
    +			if (options.isDispose()) {
    +				// Discard
    +				return disposeSavepoint(clusterClient, options.getSavepointPath());
     			} else {
    -				return handleArgException(new IllegalArgumentException(
    +				// Trigger
    +				String[] cleanedArgs = options.getArgs();
    +				JobID jobId;
    +
    +				if (cleanedArgs.length >= 1) {
    +					String jobIdString = cleanedArgs[0];
    +					try {
    +						jobId = new JobID(StringUtils.hexStringToByte(jobIdString));
    --- End diff --
    
    nit: `JobID.fromHexString(jobIdString)`


> Move dispose savepoint into ClusterClient
> -----------------------------------------
>
>                 Key: FLINK-8332
>                 URL: https://issues.apache.org/jira/browse/FLINK-8332
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Currently, the {{CliFrontend}} sends the command for disposing a savepoint. In order
to better abstract this functionality we should move it to the {{ClusterClient}}. That way
we can have different implementations of the {{ClusterClient}} (Flip-6 and old code) which
are used by the same {{CliFrontend}}.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message