flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8331) FieldParsers do not correctly set EMPT_COLUMN error state
Date Thu, 04 Jan 2018 15:28:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8331?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311496#comment-16311496
] 

ASF GitHub Bot commented on FLINK-8331:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5218#discussion_r159667815
  
    --- Diff: flink-core/src/main/java/org/apache/flink/types/parser/LongParser.java ---
    @@ -86,6 +92,11 @@ public int parseField(byte[] bytes, int startPos, int limit, byte[]
delimiter, L
     			}
     		}
     
    +		if (startPos == limit) {
    --- End diff --
    
    Why do we need this additional check? 
    This should never evaluate to `true` because the condition is checked before.
      
      


> FieldParsers do not correctly set EMPT_COLUMN error state
> ---------------------------------------------------------
>
>                 Key: FLINK-8331
>                 URL: https://issues.apache.org/jira/browse/FLINK-8331
>             Project: Flink
>          Issue Type: Bug
>          Components: Core
>    Affects Versions: 1.5.0, 1.4.1
>            Reporter: Fabian Hueske
>            Assignee: sunjincheng
>
> Some {{FieldParser}} do not correctly set the EMPTY_COLUMN error state if a field is
empty.
> Instead, they try to parse the field value from an empty String which fails, e.g., in
case of the {{DoubleParser}} with a {{NumberFormatException}}.
> The {{RowCsvInputFormat}} has a flag to interpret empty fields as {{null}} values. The
implementation requires that all {{FieldParser}} correctly return the EMPTY_COLUMN error state
in case of an empty field.
> Affected {{FieldParser}}:
> - BigDecParser
> - BigIntParser
> - DoubleParser
> - FloatParser
> - SqlDateParser
> - SqlTimeParser
> - SqlTimestampParser



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message