flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8329) Move YarnClient out of YarnClusterClient
Date Wed, 10 Jan 2018 14:01:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320279#comment-16320279
] 

ASF GitHub Bot commented on FLINK-8329:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5216#discussion_r160684153
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/AbstractYarnClusterDescriptor.java
---
    @@ -143,31 +138,48 @@
     	private YarnConfigOptions.UserJarInclusion userJarInclusion;
     
     	public AbstractYarnClusterDescriptor(
    -		org.apache.flink.configuration.Configuration flinkConfiguration,
    -		String configurationDirectory) {
    +			Configuration flinkConfiguration,
    +			String configurationDirectory,
    +			YarnClient yarnClient) {
    +
    +		yarnConfiguration = new YarnConfiguration();
    +
     		// for unit tests only
     		if (System.getenv("IN_TESTS") != null) {
     			try {
    -				conf.addResource(new File(System.getenv("YARN_CONF_DIR") + "/yarn-site.xml").toURI().toURL());
    +				yarnConfiguration.addResource(new File(System.getenv("YARN_CONF_DIR") + "/yarn-site.xml").toURI().toURL());
    --- End diff --
    
    True, will change it.


> Move YarnClient out of YarnClusterClient
> ----------------------------------------
>
>                 Key: FLINK-8329
>                 URL: https://issues.apache.org/jira/browse/FLINK-8329
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Client
>    Affects Versions: 1.5.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>              Labels: flip-6
>             Fix For: 1.5.0
>
>
> Move the {{YarnClient}} from the {{YarnClusterClient}} to the {{AbstractYarnClusterDescriptor}}
which will be responsible for the lifecycle management of the {{YarnClient}}. This change
is a clean up task which will better structure the client code.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message