flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)
Date Tue, 09 Jan 2018 15:37:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318607#comment-16318607
] 

ASF GitHub Bot commented on FLINK-8325:
---------------------------------------

Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160439631
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
    @@ -278,7 +278,14 @@ class SetOperatorsITCase(
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    +  /**
    +    * This test will checks IN for NULLs based on whether COUNT (*) and COUNT (a) are
equal. Due to
    +    * [[org.apache.flink.table.plan.rules.dataSet.DataSetAggregateWithNullValuesRule]]
will
    +    * union a NULL row in to input DataSet for non-groupBy agg. That caused COUNT (*)
and COUNT(a)
    +    * are not equal. So this test case ignored before FLINK-8355 be fixed.
    --- End diff --
    
    The test was passing before because both `COUNT(*)` and `COUNT(a)` ignore the `NULL` before
this PR. That's a bug.... please seee SQL 92 https://docs.microsoft.com/en-us/sql/t-sql/functions/count-transact-sql

    ```
    COUNT(*) returns the number of rows in a specified table without getting rid of duplicates.
It counts each row separately. This includes rows that contain null values.
    ```


> Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1) 
> ------------------------------------------------------------------
>
>                 Key: FLINK-8325
>                 URL: https://issues.apache.org/jira/browse/FLINK-8325
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.5.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> COUNT(1) with Group Window, always output 0. 
> e.g.
> DATA:
> {code}
> val data = List(
>     (1L, 1, "Hi"),
>     (2L, 2, "Hello"),
>     (4L, 2, "Hello"),
>     (8L, 3, "Hello world"),
>     (16L, 3, "Hello world"))
> {code}
> SQL:
> {code}
> SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001' SECOND, interval
'0.002' SECOND),b
> {code}
> OUTPUT:
> {code}
> 1,0,1, 
> 1,0,1, 
> 2,0,1,
> 2,0,1, 
> 2,0,2, 
> 3,0,1,
> 3,0,1
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message