flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8325) Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1)
Date Mon, 08 Jan 2018 22:27:01 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16317218#comment-16317218
] 

ASF GitHub Bot commented on FLINK-8325:
---------------------------------------

Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160250423
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -121,7 +121,7 @@ class AggregationCodeGenerator(
     
         // get parameter lists for aggregation functions
         val parametersCode = aggFields.map { inFields =>
    -      val fields = inFields.map { f =>
    +      val fields =  inFields.filter(index => index > -1).map { f =>
    --- End diff --
    
    remove double space


> Add COUNT AGG support constant parameter, i.e. COUNT(*), COUNT(1) 
> ------------------------------------------------------------------
>
>                 Key: FLINK-8325
>                 URL: https://issues.apache.org/jira/browse/FLINK-8325
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.5.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> COUNT(1) with Group Window, always output 0. 
> e.g.
> DATA:
> {code}
> val data = List(
>     (1L, 1, "Hi"),
>     (2L, 2, "Hello"),
>     (4L, 2, "Hello"),
>     (8L, 3, "Hello world"),
>     (16L, 3, "Hello world"))
> {code}
> SQL:
> {code}
> SELECT b, COUNT(1) FROM MyTable GROUP BY Hop(proctime, interval '0.001' SECOND, interval
'0.002' SECOND),b
> {code}
> OUTPUT:
> {code}
> 1,0,1, 
> 1,0,1, 
> 2,0,1,
> 2,0,1, 
> 2,0,2, 
> 3,0,1,
> 3,0,1
> {code}



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message