flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8290) Modify clientId to groupId in flink-connector-kafka-0.8
Date Tue, 16 Jan 2018 13:46:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8290?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16327130#comment-16327130
] 

ASF GitHub Bot commented on FLINK-8290:
---------------------------------------

GitHub user maqingxiang opened a pull request:

    https://github.com/apache/flink/pull/5304

    [FLINK-8290]Modify clientId to groupId in flink-connector-kafka-0.8

    Now the Clientid that consumes the all topics are constant("flink-kafka-consumer-legacy-"
+ broker.id()), and it is not easy for us to look at kafka's log, so I recommend that it be
modified to groupid.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/maqingxiang/flink FLINK-8290

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5304.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5304
    
----
commit e8c19520e9b7500548ad36afb8bd698a35d64053
Author: maqingxiang-it <maqingxiang-it@...>
Date:   2018-01-16T13:42:45Z

    Modify clientId to groupId in flink-connector-kafka-0.8

----


> Modify clientId to groupId in flink-connector-kafka-0.8
> -------------------------------------------------------
>
>                 Key: FLINK-8290
>                 URL: https://issues.apache.org/jira/browse/FLINK-8290
>             Project: Flink
>          Issue Type: Improvement
>            Reporter: xymaqingxiang
>            Priority: Major
>
> Now the Clientid that consumes the all topics are constant("flink-kafka-consumer-legacy-"
+ broker.id()), and it is not easy for us to look at kafka's log, so I recommend that it be
modified to groupid.
> We can modify the SimpleConsumerThread.java file, as shown below:
> {code:java}
> private final String clientId;
> ...
> this.clientId = config.getProperty("group.id", "flink-kafka-consumer-legacy-" + broker.id());
> ...
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message