flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8242) ClassCastException in OrcTableSource.toOrcPredicate
Date Wed, 24 Jan 2018 11:13:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8242?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16337413#comment-16337413
] 

ASF GitHub Bot commented on FLINK-8242:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5345#discussion_r163517596
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/util/RexProgramExtractor.scala
---
    @@ -214,6 +213,10 @@ class RexNodeToExpressionConverter(
             // convert to BigDecimal
             literal.getValueAs(classOf[java.math.BigDecimal])
     
    +      case _ if literal.getValue.isInstanceOf[NlsString] =>
    --- End diff --
    
    This should not be necessary because it is already done line 204. All tests are still
working if I remove this change.


> ClassCastException in OrcTableSource.toOrcPredicate
> ---------------------------------------------------
>
>                 Key: FLINK-8242
>                 URL: https://issues.apache.org/jira/browse/FLINK-8242
>             Project: Flink
>          Issue Type: Bug
>          Components: Batch Connectors and Input/Output Formats
>    Affects Versions: 1.4.0
>            Reporter: Fabian Hueske
>            Assignee: Fabian Hueske
>            Priority: Critical
>             Fix For: 1.5.0, 1.4.1
>
>
> The {{OrcTableSource}} tries to cast all predicate literals to {{Serializable}} in its
{{toOrcPredicate()}} method. This fails with a {{ClassCastException}} if a literal is not
serializable.
> Instead of failing, we should ignore the predicate and log a WARN message.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message