flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8207) Unify TestPooledBufferProvider and TestInfinityBufferProvider
Date Mon, 08 Jan 2018 08:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8207?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315854#comment-16315854

ASF GitHub Bot commented on FLINK-8207:

GitHub user NicoK opened a pull request:


    [FLINK-8207][network-tests] Unify TestInfiniteBufferProvider and TestPooledBufferProvider

    ## What is the purpose of the change
    `TestPooledBufferProvider` and `TestInfiniteBufferProvider` share a low of code and could
be unified into a single class for simplicity.
    This PR is based on #4533.
    ## Brief change log
    - merge `TestInfinityBufferProvider` functionality into `TestPooledBufferProvider`
    ## Verifying this change
    This change is already covered by existing tests, since we are changing a test utility.
    ## Does this pull request potentially affect one of the following parts:
      - Dependencies (does it add or upgrade a dependency): **no**
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: **no**
      - The serializers: **no**
      - The runtime per-record code paths (performance sensitive): **no**
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: **no**
      - The S3 file system connector: **no**
    ## Documentation
      - Does this pull request introduce a new feature? **no**
      - If yes, how is the feature documented? **not applicable**

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/NicoK/flink flink-8207

Alternatively you can review and apply these changes as the patch at:


To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5250
commit 82e3fa72af108c92a179ea441bf67e8b2e494d23
Author: Zhijiang <wangzhijiang999@...>
Date:   2017-08-10T05:29:13Z

    [FLINK-7406][network] Implement Netty receiver incoming pipeline for credit-based

commit 7c364f84df0969cc135c5a9835681c9d2d8e678a
Author: Zhijiang <wangzhijiang999@...>
Date:   2017-09-28T15:39:26Z

    [FLINK-7416][network] Implement Netty receiver outgoing pipeline for credit-based

commit cfe85ced9a4c5bbc342e527d8b59e17ecf1cdad6
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2017-12-18T14:26:20Z

    [hotfix][network] Drop redundant this reference usages

commit dc5427696476d898da6ece19c7e05f6063ed98ae
Author: Piotr Nowojski <piotr.nowojski@...>
Date:   2017-12-04T14:13:57Z

    [FLINK-8207][network-tests] Unify TestInfiniteBufferProvider and TestPooledBufferProvider


> Unify TestPooledBufferProvider and TestInfinityBufferProvider
> -------------------------------------------------------------
>                 Key: FLINK-8207
>                 URL: https://issues.apache.org/jira/browse/FLINK-8207
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: Piotr Nowojski
>            Assignee: Piotr Nowojski
>             Fix For: 1.5.0

This message was sent by Atlassian JIRA

View raw message