flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8203) Make schema definition of DataStream/DataSet to Table conversion more flexible
Date Fri, 05 Jan 2018 09:56:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8203?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16312799#comment-16312799

ASF GitHub Bot commented on FLINK-8203:

Github user twalthr commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/StreamTableEnvironment.scala
    @@ -464,23 +470,29 @@ abstract class StreamTableEnvironment(
             throw new TableException(
               "The rowtime attribute can only be defined once in a table schema.")
           } else {
    -        val mappedIdx = streamType match {
    -          case pti: PojoTypeInfo[_] =>
    -            pti.getFieldIndex(origName.getOrElse(name))
    -          case _ => idx;
    -        }
    -        // check type of field that is replaced
    -        if (mappedIdx < 0) {
    -          throw new TableException(
    -            s"The rowtime attribute can only replace a valid field. " +
    -              s"${origName.getOrElse(name)} is not a field of type $streamType.")
    -        }
    -        else if (mappedIdx < fieldTypes.length &&
    -          !(TypeCheckUtils.isLong(fieldTypes(mappedIdx)) ||
    -            TypeCheckUtils.isTimePoint(fieldTypes(mappedIdx)))) {
    -          throw new TableException(
    -            s"The rowtime attribute can only replace a field with a valid time type,
" +
    -              s"such as Timestamp or Long. But was: ${fieldTypes(mappedIdx)}")
    +        // if the fields are referenced by position,
    +        // it is possible to replace an existing field or append the time attribute at
the end
    +        if (isReferenceByPosition) {
    --- End diff --
    This method does no need to distinguish between types anymore. The `isReferenceByPosition`
method is doing that. The type checking is done earlier in `getFieldInfo()`. 

> Make schema definition of DataStream/DataSet to Table conversion more flexible
> ------------------------------------------------------------------------------
>                 Key: FLINK-8203
>                 URL: https://issues.apache.org/jira/browse/FLINK-8203
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.4.0, 1.5.0
>            Reporter: Fabian Hueske
>            Assignee: Timo Walther
> When converting or registering a {{DataStream}} or {{DataSet}} as {{Table}}, the schema
of the table can be defined (by default it is extracted from the {{TypeInformation}}.
> The schema needs to be manually specified to select (project) fields, rename fields,
or define time attributes. Right now, there are several limitations how the fields can be
defined that also depend on the type of the {{DataStream}} / {{DataSet}}. Types with explicit
field ordering (e.g., tuples, case classes, Row) require schema definition based on the position
of fields. Pojo types which have no fixed order of fields, require to refer to fields by name.
Moreover, there are several restrictions on how time attributes can be defined, e.g., event
time attribute must replace an existing field or be appended and proctime attributes must
be appended.
> I think we can make the schema definition more flexible and provide two modes:
> 1. Reference input fields by name: All fields in the schema definition are referenced
by name (and possibly renamed using an alias ({{as}}). In this mode, fields can be reordered
and projected out. Moreover, we can define proctime and eventtime attributes at arbitrary
positions using arbitrary names (except those that existing the result schema). This mode
can be used for any input type, including POJOs. This mode is used if all field references
exist in the input type.
> 2. Reference input fields by position: Field references might not refer to existing fields
in the input type. In this mode, fields are simply renamed. Event-time attributes can replace
the field on their position in the input data (if it is of correct type) or be appended at
the end. Proctime attributes must be appended at the end. This mode can only be used if the
input type has a defined field order (tuple, case class, Row).
> We need to add more tests the check for all combinations of input types and schema definition

This message was sent by Atlassian JIRA

View raw message