flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8175) remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala
Date Wed, 03 Jan 2018 20:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8175?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16310240#comment-16310240

ASF GitHub Bot commented on FLINK-8175:

Github user bowenli86 commented on the issue:

    @StephanEwen Thanks Stephan. To your comments:
    1. in order to have `experiemental/scala` package in `flink-streaming-scala`, I have to
make `DataStreamUtils` its own class to avoid package name collisions with `scala`
    2. I don't think checkstyle of the whole project`flink-streaming-scala` is active. I did
some tests which removed comments and left unused class imports, the build still passed. I
think we should address enabling checkstyle separately, may need to reopen[FLINK-6902]( https://issues.apache.org/jira/browse/FLINK-6902).
cc @zentol 

> remove flink-streaming-contrib and migrate its classes to flink-streaming-java/scala
> ------------------------------------------------------------------------------------
>                 Key: FLINK-8175
>                 URL: https://issues.apache.org/jira/browse/FLINK-8175
>             Project: Flink
>          Issue Type: Sub-task
>    Affects Versions: 1.5.0
>            Reporter: Bowen Li
>            Assignee: Bowen Li
>             Fix For: 1.5.0
> I propose removing flink-streaming-contrib from flink-contrib, and migrating its classes
to flink-streaming-java/scala for the following reasons:
> - flink-streaming-contrib is so small that it only has 4 classes (3 java and 1 scala),
and they don't need a dedicated jar for Flink to distribute and maintain it and for users
to deal with the overhead of dependency management
> - the 4 classes in flink-streaming-contrib are logically more tied to flink-streaming-java/scala,
and thus can be easily migrated
> - flink-contrib is already too crowded and noisy. It contains lots of sub modules with
different purposes which confuse developers and users, and they lack a proper project hierarchy
> To take a step even forward, I would argue that even flink-contrib should be removed
and all its submodules should be migrated to other top-level modules for the following reasons:
1) Apache Flink the whole project itself is a result of contributions from many developers,
there's no reason to highlight some contributions in a dedicated module named 'contrib' 2)
flink-contrib inherently doesn't have a good hierarchy to hold submodules

This message was sent by Atlassian JIRA

View raw message