flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8122) Name all table sinks and sources
Date Thu, 04 Jan 2018 15:38:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8122?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16311517#comment-16311517
] 

ASF GitHub Bot commented on FLINK-8122:
---------------------------------------

Github user twalthr commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5068#discussion_r159681109
  
    --- Diff: flink-connectors/flink-connector-kafka-base/src/test/java/org/apache/flink/streaming/connectors/kafka/KafkaTableSinkTestBase.java
---
    @@ -54,6 +57,7 @@
     	@Test
     	public void testKafkaTableSink() throws Exception {
     		DataStream dataStream = mock(DataStream.class);
    +		when(dataStream.addSink(any(SinkFunction.class))).thenReturn(mock(DataStreamSink.class));
    --- End diff --
    
    It fixes the test.


> Name all table sinks and sources
> --------------------------------
>
>                 Key: FLINK-8122
>                 URL: https://issues.apache.org/jira/browse/FLINK-8122
>             Project: Flink
>          Issue Type: Improvement
>          Components: Table API & SQL
>    Affects Versions: 1.4.0
>            Reporter: Timo Walther
>            Assignee: Xingcan Cui
>
> Not all table sink and sources have proper names. Therefore, they are displayed as "Unnamed"
in the logs and Web UI (e.g. CsvTableSink). We should add names for all built-in connectors.
Having information about the table sink name (via {{INSERT INTO}}) would be even better.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message