flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8101) Elasticsearch 6.x support
Date Wed, 31 Jan 2018 12:19:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346723#comment-16346723
] 

ASF GitHub Bot commented on FLINK-8101:
---------------------------------------

Github user yew1eb commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5374#discussion_r165035180
  
    --- Diff: flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/Elasticsearch53ApiCallBridge.java
---
    @@ -0,0 +1,138 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one or more
    + * contributor license agreements.  See the NOTICE file distributed with
    + * this work for additional information regarding copyright ownership.
    + * The ASF licenses this file to You under the Apache License, Version 2.0
    + * (the "License"); you may not use this file except in compliance with
    + * the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.elasticsearch53;
    +
    +import org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchApiCallBridge;
    +import org.apache.flink.streaming.connectors.elasticsearch.ElasticsearchSinkBase;
    +import org.apache.flink.streaming.connectors.elasticsearch.RequestIndexer;
    +import org.apache.flink.streaming.connectors.elasticsearch.util.ElasticsearchUtils;
    +import org.apache.flink.util.Preconditions;
    +
    +import org.elasticsearch.action.bulk.BackoffPolicy;
    +import org.elasticsearch.action.bulk.BulkItemResponse;
    +import org.elasticsearch.action.bulk.BulkProcessor;
    +import org.elasticsearch.client.Client;
    +import org.elasticsearch.client.transport.TransportClient;
    +import org.elasticsearch.common.network.NetworkModule;
    +import org.elasticsearch.common.settings.Settings;
    +import org.elasticsearch.common.transport.TransportAddress;
    +import org.elasticsearch.common.unit.TimeValue;
    +import org.elasticsearch.transport.Netty3Plugin;
    +import org.elasticsearch.transport.client.PreBuiltTransportClient;
    +import org.slf4j.Logger;
    +import org.slf4j.LoggerFactory;
    +
    +import javax.annotation.Nullable;
    +
    +import java.net.InetSocketAddress;
    +import java.util.List;
    +import java.util.Map;
    +import java.util.concurrent.atomic.AtomicLong;
    +
    +/**
    + * Implementation of {@link ElasticsearchApiCallBridge} for Elasticsearch 5.3 and later
versions.
    + */
    +public class Elasticsearch53ApiCallBridge extends ElasticsearchApiCallBridge {
    +
    +	private static final long serialVersionUID = -5222683870097809633L;
    +
    +	private static final Logger LOG = LoggerFactory.getLogger(Elasticsearch53ApiCallBridge.class);
    +
    +	/**
    +	 * User-provided transport addresses.
    +	 *
    +	 * <p>We are using {@link InetSocketAddress} because {@link TransportAddress}
is not serializable in Elasticsearch 5.x.
    +	 */
    +	private final List<InetSocketAddress> transportAddresses;
    +
    +	Elasticsearch53ApiCallBridge(List<InetSocketAddress> transportAddresses) {
    +		Preconditions.checkArgument(transportAddresses != null && !transportAddresses.isEmpty());
    +		this.transportAddresses = transportAddresses;
    +	}
    +
    +	@Override
    +	public AutoCloseable createClient(Map<String, String> clientConfig) {
    +		Settings settings = Settings.builder().put(clientConfig)
    +			.put(NetworkModule.HTTP_TYPE_KEY, Netty3Plugin.NETTY_HTTP_TRANSPORT_NAME)
    +			.put(NetworkModule.TRANSPORT_TYPE_KEY, Netty3Plugin.NETTY_TRANSPORT_NAME)
    +			.build();
    +
    +		TransportClient transportClient = new PreBuiltTransportClient(settings);
    +		for (TransportAddress transport : ElasticsearchUtils.convertInetSocketAddresses(transportAddresses))
{
    +			transportClient.addTransportAddress(transport);
    +		}
    +
    +		// verify that we actually are connected to a cluster
    +		if (transportClient.connectedNodes().isEmpty()) {
    +			throw new RuntimeException("Elasticsearch client is not connected to any Elasticsearch
nodes!");
    +		}
    +
    +		if (LOG.isInfoEnabled()) {
    --- End diff --
    
    Check` Logger info Enabled` is unnecessary, because in the info() method of Logger itself
`if(Logger. isInfoEnabled()) `was checked.


> Elasticsearch 6.x support
> -------------------------
>
>                 Key: FLINK-8101
>                 URL: https://issues.apache.org/jira/browse/FLINK-8101
>             Project: Flink
>          Issue Type: New Feature
>          Components: ElasticSearch Connector
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Flavio Pompermaier
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Recently, elasticsearch 6.0.0 was released: https://www.elastic.co/blog/elasticsearch-6-0-0-released
 
> The minimum version of ES6 compatible Elasticsearch Java Client is 5.6.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message