flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-8101) Elasticsearch 6.x support
Date Wed, 31 Jan 2018 12:04:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-8101?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16346684#comment-16346684
] 

ASF GitHub Bot commented on FLINK-8101:
---------------------------------------

Github user yew1eb commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5374#discussion_r165032079
  
    --- Diff: flink-connectors/flink-connector-elasticsearch5.3/src/main/java/org/apache/flink/streaming/connectors/elasticsearch53/BulkProcessorIndexer.java
---
    @@ -0,0 +1,57 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *    http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.streaming.connectors.elasticsearch53;
    +
    +import org.apache.flink.streaming.connectors.elasticsearch.RequestIndexer;
    +
    +import org.elasticsearch.action.ActionRequest;
    +import org.elasticsearch.action.DocWriteRequest;
    +import org.elasticsearch.action.bulk.BulkProcessor;
    +
    +import java.util.concurrent.atomic.AtomicLong;
    +
    +/**
    + * Implementation of a {@link RequestIndexer}, using a {@link BulkProcessor}.
    + * {@link ActionRequest ActionRequests} will be converted to {@link DocWriteRequest}
    + * and will be buffered before sending a bulk request to the Elasticsearch cluster.
    + */
    +public class BulkProcessorIndexer implements RequestIndexer {
    +
    +	private final BulkProcessor bulkProcessor;
    +	private final boolean flushOnCheckpoint;
    +	private final AtomicLong numPendingRequestsRef;
    +
    +	public BulkProcessorIndexer(BulkProcessor bulkProcessor,
    +								boolean flushOnCheckpoint,
    +								AtomicLong numPendingRequests) {
    +		this.bulkProcessor = bulkProcessor;
    +		this.flushOnCheckpoint = flushOnCheckpoint;
    +		this.numPendingRequestsRef = numPendingRequests;
    +	}
    +
    +	@Override
    +	public void add(ActionRequest... actionRequests) {
    +		for (ActionRequest actionRequest : actionRequests) {
    +			if (flushOnCheckpoint) {
    +				numPendingRequestsRef.getAndIncrement();
    +			}
    +			this.bulkProcessor.add((DocWriteRequest) actionRequest);
    --- End diff --
    
    Are you sure that `ActionRequest` type can be cast to `DocWriteRequest` type?


> Elasticsearch 6.x support
> -------------------------
>
>                 Key: FLINK-8101
>                 URL: https://issues.apache.org/jira/browse/FLINK-8101
>             Project: Flink
>          Issue Type: New Feature
>          Components: ElasticSearch Connector
>    Affects Versions: 1.4.0
>            Reporter: Hai Zhou UTC+8
>            Assignee: Flavio Pompermaier
>            Priority: Major
>             Fix For: 1.5.0
>
>
> Recently, elasticsearch 6.0.0 was released: https://www.elastic.co/blog/elasticsearch-6-0-0-released
 
> The minimum version of ES6 compatible Elasticsearch Java Client is 5.6.0



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message