flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7909) Unify cluster creation for test bases
Date Mon, 08 Jan 2018 15:25:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316474#comment-16316474

ASF GitHub Bot commented on FLINK-7909:

Github user tillrohrmann commented on a diff in the pull request:

    --- Diff: flink-examples/flink-examples-streaming/src/main/java/org/apache/flink/streaming/examples/windowing/TopSpeedWindowing.java
    @@ -55,6 +55,7 @@ public static void main(String[] args) throws Exception {
     		final StreamExecutionEnvironment env = StreamExecutionEnvironment.getExecutionEnvironment();
    +		env.setParallelism(1);
    --- End diff --
    Yes it's because of `TopSpeedWindowingExampleITCase`. However, it's not very nice and
I decided to rework the `TopSpeedWindowingExampleITCase` instead.

> Unify cluster creation for test bases
> -------------------------------------
>                 Key: FLINK-7909
>                 URL: https://issues.apache.org/jira/browse/FLINK-7909
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
> Flink contains different test bases, e.g. {{AbstractTestBase}}, {{MultipleProgramsTestBase}},
{{JavaProgramTestBase}} and the {{StreamingMultipleProgramsTestBase}}. Some of them start
resources ({{FlinkMiniCluster}}) automatically, while others expose a start method. Some test
bases set the {{ExecutionEnvironment}} while others use the {{FlinkMiniCluster}} directly.
In order to make things more maintainable I propose to unify these test bases a bit and introduce
an {{ExternalResource}} which encapsulates the resource start up and shut down.

This message was sent by Atlassian JIRA

View raw message