flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7909) Unify cluster creation for test bases
Date Mon, 08 Jan 2018 14:39:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16316410#comment-16316410
] 

ASF GitHub Bot commented on FLINK-7909:
---------------------------------------

Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4896#discussion_r160158137
  
    --- Diff: flink-examples/flink-examples-streaming/src/test/scala/org/apache/flink/streaming/scala/examples/StreamingExamplesITCase.scala
---
    @@ -23,8 +23,7 @@ import java.io.File
     import org.apache.commons.io.FileUtils
     import org.apache.flink.core.fs.FileSystem.WriteMode
     import org.apache.flink.streaming.api.TimeCharacteristic
    -import org.apache.flink.streaming.api.scala._
    -import org.apache.flink.streaming.api.scala.StreamExecutionEnvironment
    +import org.apache.flink.streaming.api.scala.{StreamExecutionEnvironment, _}
    --- End diff --
    
    Will change it.


> Unify cluster creation for test bases
> -------------------------------------
>
>                 Key: FLINK-7909
>                 URL: https://issues.apache.org/jira/browse/FLINK-7909
>             Project: Flink
>          Issue Type: Improvement
>          Components: Tests
>    Affects Versions: 1.4.0
>            Reporter: Till Rohrmann
>            Assignee: Till Rohrmann
>
> Flink contains different test bases, e.g. {{AbstractTestBase}}, {{MultipleProgramsTestBase}},
{{JavaProgramTestBase}} and the {{StreamingMultipleProgramsTestBase}}. Some of them start
resources ({{FlinkMiniCluster}}) automatically, while others expose a start method. Some test
bases set the {{ExecutionEnvironment}} while others use the {{FlinkMiniCluster}} directly.
In order to make things more maintainable I propose to unify these test bases a bit and introduce
an {{ExternalResource}} which encapsulates the resource start up and shut down.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message