flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7511) Remove dead code after dropping backward compatibility with <=1.2
Date Tue, 09 Jan 2018 10:44:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7511?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16318239#comment-16318239
] 

ASF GitHub Bot commented on FLINK-7511:
---------------------------------------

Github user dawidwys commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4587#discussion_r160372500
  
    --- Diff: flink-libraries/flink-cep/src/main/java/org/apache/flink/cep/nfa/NFA.java ---
    @@ -150,16 +126,13 @@
     	 */
     	private boolean nfaChanged;
     
    -	public NFA(
    -			final TypeSerializer<T> eventSerializer,
    +	public NFA(final TypeSerializer<T> eventSerializer,
     			final long windowTime,
     			final boolean handleTimeout) {
    -
     		this.eventSerializer = eventSerializer;
    --- End diff --
    
    this PR does not change anything in this manner (previously it also should not be null),
but I agree we can add this check


> Remove dead code after dropping backward compatibility with <=1.2
> -----------------------------------------------------------------
>
>                 Key: FLINK-7511
>                 URL: https://issues.apache.org/jira/browse/FLINK-7511
>             Project: Flink
>          Issue Type: Improvement
>          Components: CEP
>    Affects Versions: 1.4.0
>            Reporter: Dawid Wysakowicz
>            Assignee: Dawid Wysakowicz
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message