flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based
Date Wed, 10 Jan 2018 16:16:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320521#comment-16320521
] 

ASF GitHub Bot commented on FLINK-7456:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r160694722
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
---
    @@ -88,6 +94,37 @@ public void run() {
     		});
     	}
     
    +	/**
    +	 * Try to enqueue the reader once receiving credit notification from the consumer or
receiving
    +	 * non-empty reader notification from the producer. Only one thread would trigger the
actual
    +	 * enqueue after checking the reader's availability, so there is no race condition here.
    +	 */
    +	@VisibleForTesting
    +	void triggerEnqueueAvailableReader(final SequenceNumberingViewReader reader) throws
Exception {
    +		if (!reader.isRegisteredAvailable() && reader.isAvailable()) {
    +			enqueueAvailableReader(reader);
    +		}
    +	}
    +
    +	@VisibleForTesting
    +	void enqueueAvailableReader(final SequenceNumberingViewReader reader) throws Exception
{
    --- End diff --
    
    actually, we can inline this into the first one, make this `private`, and reduce `Mockito`
use in the tests if we just made the `availableReaders` field accessible to the tests, e.g.
    ```
    	/**
    	 * Accesses internal state to verify reader registration in the unit tests.
    	 *
    	 * <p><strong>Do not use anywhere else!</strong>
    	 *
    	 * @return readers which are enqueued available for transferring data
    	 */
    	@VisibleForTesting
    	ArrayDeque<SequenceNumberingViewReader> getAvailableReaders() {
    		return availableReaders;
    	}
    ```


> Implement Netty sender incoming pipeline for credit-based
> ---------------------------------------------------------
>
>                 Key: FLINK-7456
>                 URL: https://issues.apache.org/jira/browse/FLINK-7456
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> On sender side, each subpartition view maintains an atomic integer {{currentCredit}}
from receiver. Once receiving the messages of {{PartitionRequest}} and {{AddCredit}}, the
{{currentCredit}} is added by deltas.
> Each view also maintains an atomic boolean field to mark it as registered available for
transfer to make sure it is enqueued in handler only once. If the {{currentCredit}} increases
from zero and there are available buffers in the subpartition, the corresponding view will
be enqueued for transferring data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message