flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7456) Implement Netty sender incoming pipeline for credit-based
Date Mon, 08 Jan 2018 08:03:03 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7456?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16315833#comment-16315833
] 

ASF GitHub Bot commented on FLINK-7456:
---------------------------------------

Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r159400371
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/SequenceNumberingViewReader.java
---
    @@ -77,6 +83,37 @@ void requestSubpartitionView(
     		}
     	}
     
    +	public void addCredit(int credit) {
    +		numCreditsAvailable += credit;
    +	}
    +
    +	public void notifyAvailableChanged(boolean update) {
    --- End diff --
    
    `notifyAvailabilityChanged` or actually rather `setAvailability`?
    also, please add a comment on what this is about / what "availability" means here
      


> Implement Netty sender incoming pipeline for credit-based
> ---------------------------------------------------------
>
>                 Key: FLINK-7456
>                 URL: https://issues.apache.org/jira/browse/FLINK-7456
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Network
>            Reporter: zhijiang
>            Assignee: zhijiang
>             Fix For: 1.5.0
>
>
> This is a part of work for credit-based network flow control.
> On sender side, each subpartition view maintains an atomic integer {{currentCredit}}
from receiver. Once receiving the messages of {{PartitionRequest}} and {{AddCredit}}, the
{{currentCredit}} is added by deltas.
> Each view also maintains an atomic boolean field to mark it as registered available for
transfer to make sure it is enqueued in handler only once. If the {{currentCredit}} increases
from zero and there are available buffers in the subpartition, the corresponding view will
be enqueued for transferring data.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message