flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-7095) Add proper command line parsing tool to TaskManagerRunner.main
Date Sat, 27 Jan 2018 13:30:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-7095?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16342130#comment-16342130
] 

ASF GitHub Bot commented on FLINK-7095:
---------------------------------------

GitHub user zhangminglei opened a pull request:

    https://github.com/apache/flink/pull/5375

    [FLINK-7095] [TaskManager] Add Command line parsing tool to TaskManag…

    ## What is the purpose of the change
    
    *Add a proper command line parsing tool to the entry point of the TaskManagerRunner#main.*
    
    
    ## Brief change log
      - *Use Commons CLI as tool to implement this functionality.*
      - *Remove the original way of ParameterTool.*
    
    ## Verifying this change
    This change is a trivial rework / code cleanup without any test coverage.
    
    ## Does this pull request potentially affect one of the following parts:
    
      - Dependencies (does it add or upgrade a dependency): (no)
      - The public API, i.e., is any changed class annotated with `@Public(Evolving)`: (no)
      - The serializers: (no)
      - The runtime per-record code paths (performance sensitive): (don't know)
      - Anything that affects deployment or recovery: JobManager (and its components), Checkpointing,
Yarn/Mesos, ZooKeeper: (don't know)
      - The S3 file system connector: (no)
    
    ## Documentation
    
      - Does this pull request introduce a new feature? (yes)
      - If yes, how is the feature documented? (JavaDocs)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zhangminglei/flink flink-7095

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5375.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5375
    
----
commit 7db40095c16ab4f6330343efb3a9703674b194ed
Author: zhangminglei <zml13856086071@...>
Date:   2018-01-27T13:23:37Z

    [FLINK-7095] [TaskManager] Add Command line parsing tool to TaskManagerRunner.main

----


> Add proper command line parsing tool to TaskManagerRunner.main
> --------------------------------------------------------------
>
>                 Key: FLINK-7095
>                 URL: https://issues.apache.org/jira/browse/FLINK-7095
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Cluster Management
>            Reporter: Till Rohrmann
>            Priority: Minor
>              Labels: flip-6
>
> We need to add a proper command line parsing tool to the entry point of the {{TaskManagerRunner#main}}.
At the moment, we are simply using the {{ParameterTool}} as a temporary solution.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message