flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (FLINK-5823) Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
Date Wed, 10 Jan 2018 18:41:00 GMT

    [ https://issues.apache.org/jira/browse/FLINK-5823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16320816#comment-16320816
] 

ASF GitHub Bot commented on FLINK-5823:
---------------------------------------

Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5248
  
    Thank you for the thorough review. Here is a summary of follow-ups from my side:
      - Investigate more if we find a better way for configuration than the `ConfigurableStateBackend`.
      - Adjust some method names.
      - Possible look at a different name for `CheckpointStorage` to avoid confusion with
`CompletedCheckpointStore`. We might actually decide to rename `CompletedCheckpointStore`
to `CompletedCheckpointsRegistry`, because that is really what it is. ZK registers the completed
checkpoints, it does not store them (after this PR that is more true even than before).
    
    One of the bigger comments (to replace String by a stronger typed Pointer class) is something
I think will not easily work, because Strings is really what we get from the command line,
REST interface, ZK. Any extra wrapping would not add any more safety at this point. When we
see that we actually can add more safety, we should refactor this.


> Store Checkpoint Root Metadata in StateBackend (not in HA custom store)
> -----------------------------------------------------------------------
>
>                 Key: FLINK-5823
>                 URL: https://issues.apache.org/jira/browse/FLINK-5823
>             Project: Flink
>          Issue Type: Sub-task
>          Components: State Backends, Checkpointing
>            Reporter: Stephan Ewen
>            Assignee: Stephan Ewen
>            Priority: Blocker
>             Fix For: 1.5.0
>
>




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message