flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5383: [hotfix][kafka-tests] Do not hide original excepti...
Date Tue, 30 Jan 2018 14:19:01 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5383#discussion_r164754175
  
    --- Diff: flink-connectors/flink-connector-kafka-0.11/src/test/java/org/apache/flink/streaming/connectors/kafka/FlinkKafkaProducer011ITCase.java
---
    @@ -592,24 +595,21 @@ private Properties createProperties() {
     		return properties;
     	}
     
    -	private void assertIsCausedBy(Class<?> clazz, Throwable ex) {
    +	private static <T> Optional<T> isCausedBy(Class<T> clazz, Throwable
ex) {
    --- End diff --
    
    Better to use `ExceptionUtils#findThrowable`.


---

Mime
View raw message