flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tzulitai <...@git.apache.org>
Subject [GitHub] flink pull request #5230: [FLINK-8345] Add iterator of keyed state on broadc...
Date Thu, 25 Jan 2018 19:25:59 GMT
Github user tzulitai commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5230#discussion_r163932340
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java
---
    @@ -64,11 +70,18 @@ public int getVersion() {
     	public void write(DataOutputView out) throws IOException {
     		super.write(out);
     
    -		out.writeShort(stateMetaInfoSnapshots.size());
    -		for (RegisteredOperatorBackendStateMetaInfo.Snapshot<?> kvState : stateMetaInfoSnapshots)
{
    +		out.writeShort(operatorStateMetaInfoSnapshots.size());
    +		for (RegisteredOperatorBackendStateMetaInfo.Snapshot<?> kvState : operatorStateMetaInfoSnapshots)
{
    --- End diff --
    
    the naming of the `kvState` variable here is actually a bit odd


---

Mime
View raw message