flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5309: [FLINK-8450] [flip6] Make JobMaster/DispatcherGate...
Date Wed, 24 Jan 2018 15:00:45 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5309#discussion_r163549462
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/dispatcher/Dispatcher.java
---
    @@ -331,13 +331,13 @@ public void start() throws Exception {
     	}
     
     	@Override
    -	public CompletableFuture<AccessExecutionGraph> requestJob(JobID jobId, Time timeout)
{
    +	public CompletableFuture<ArchivedExecutionGraph> requestJob(JobID jobId, Time
timeout) {
    --- End diff --
    
    nit: The git commit message is wrong: 
    
    *Let JobMasterGateway#requestJob and DispatcherGateway#requestJob return a CompletableFuture\<SerializableExecutionGraph\>*


---

Mime
View raw message