flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...
Date Tue, 23 Jan 2018 07:26:56 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5312#discussion_r163161003
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/program/rest/RestClusterClient.java
---
    @@ -327,13 +376,14 @@ public T getClusterId() {
     	}
     
     	private <R, A extends AsynchronouslyCreatedResource<R>> R waitForResource(
    -			final SupplierWithException<CompletableFuture<A>, IOException> resourceFutureSupplier)
    +			final Supplier<CompletableFuture<A>> resourceFutureSupplier)
     				throws IOException, InterruptedException, ExecutionException, TimeoutException {
     		A asynchronouslyCreatedResource;
     		long attempt = 0;
     		while (true) {
     			final CompletableFuture<A> responseFuture = resourceFutureSupplier.get();
    --- End diff --
    
    Made the method `waitForResource ` non-blocking.


---

Mime
View raw message