flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5312: [FLINK-8344][WIP] Add support for HA to RestCluste...
Date Fri, 19 Jan 2018 18:41:15 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5312#discussion_r162690747
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/webmonitor/WebMonitorEndpoint.java
---
    @@ -144,6 +154,15 @@ public WebMonitorEndpoint(
     			metricQueryServiceRetriever,
     			executor,
     			restConfiguration.getTimeout());
    +
    +		this.leaderElectionService = Preconditions.checkNotNull(leaderElectionService);
    +		this.fatalErrorHandler = Preconditions.checkNotNull(fatalErrorHandler);
    +	}
    +
    +	@Override
    +	public void start() throws Exception {
    +		super.start();
    +		leaderElectionService.start(this);
    --- End diff --
    
    We should also stop the `leaderElectionService`.


---

Mime
View raw message