flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Fri, 19 Jan 2018 15:42:53 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r162645683
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/nodes/dataset/DataSetAggregate.scala
---
    @@ -157,6 +158,7 @@ class DataSetAggregate(
           } else {
             inputDS
               .reduceGroup(finalAgg)
    +          .mapPartition(emptyProcessMapPartition.get)
    --- End diff --
    
    We should implement the pre-aggregated non-grouped agg also with `mapPartition` then,
IMO.


---

Mime
View raw message