flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Fri, 19 Jan 2018 15:42:52 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r162643699
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/runtime/aggregate/AggregateUtil.scala
---
    @@ -829,7 +833,8 @@ object AggregateUtil {
           outputType: RelDataType,
           groupings: Array[Int]): (Option[DataSetPreAggFunction],
             Option[TypeInformation[Row]],
    -        RichGroupReduceFunction[Row, Row]) = {
    +        RichGroupReduceFunction[Row, Row],
    +        Option[MapPartitionFunction[Row, Row]]) = {
    --- End diff --
    
    Please remove this parameter and extend `DataSetFinalAggFunction` to also implement `RichMapPartitionFunction`
such that it can be used as both (similar to `DataSetPreAggFunction`).


---

Mime
View raw message