flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Fri, 19 Jan 2018 15:42:52 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r162643053
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/plan/rules/FlinkRuleSets.scala
---
    @@ -164,7 +164,6 @@ object FlinkRuleSets {
         // translate to Flink DataSet nodes
         DataSetWindowAggregateRule.INSTANCE,
         DataSetAggregateRule.INSTANCE,
    -    DataSetAggregateWithNullValuesRule.INSTANCE,
    --- End diff --
    
    Please move the changes to remove this rule into a separate PR.


---

Mime
View raw message