flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5313: [FLINK-8455] [core] Make 'org.apache.hadoop.' a 'p...
Date Fri, 19 Jan 2018 08:23:44 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5313#discussion_r162559654
  
    --- Diff: flink-core/src/test/java/org/apache/flink/configuration/ParentFirstPatternsTest.java
---
    @@ -0,0 +1,76 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.configuration;
    +
    +import org.junit.Test;
    +
    +import java.util.Arrays;
    +import java.util.HashSet;
    +
    +import static org.junit.Assert.assertTrue;
    +
    +/**
    + * Test that checks that all packages that need to be loaded 'parent-first' are also
    + * in the parent-first patterns.
    + */
    +public class ParentFirstPatternsTest {
    --- End diff --
    
    `extends TestLogger` would be a nice addition.


---

Mime
View raw message