flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From EronWright <...@git.apache.org>
Subject [GitHub] flink pull request #5307: [FLINK-8431] [mesos] Allow to specify # GPUs for T...
Date Thu, 18 Jan 2018 21:26:21 GMT
Github user EronWright commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5307#discussion_r162468156
  
    --- Diff: flink-mesos/src/main/java/org/apache/flink/mesos/scheduler/Offer.java ---
    @@ -156,6 +164,16 @@ public long getOfferedTime() {
     		return attributeMap;
     	}
     
    +	@Override
    +	public Double getScalarValue(String name) {
    +		return aggregatedScalarResourceMap.getOrDefault(name, 0.0);
    +	}
    +
    +	@Override
    +	public Map<String, Double> getScalarValues() {
    +		return aggregatedScalarResourceMap;
    --- End diff --
    
    I notice that we return all scalar resource types (`cpus`, `gpus`, ...) here, but in `LaunchableMesosWorker::getScalarRequests`
we return only the generic resource types (`gpus`).   Would you please double-check that this
is expected by Fenzo?   I wouldn't want Fenzo to double-count the `cpus` or something.


---

Mime
View raw message