flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...
Date Mon, 15 Jan 2018 17:34:36 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r161546199
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/io/network/netty/PartitionRequestClientHandlerTest.java
---
    @@ -372,16 +379,18 @@ public void testNotifyCreditAvailableAfterReleased() throws Exception
{
     
     			assertEquals(2, inputChannel.getUnannouncedCredit());
     
    -			// The PartitionRequestClient is tied to PartitionRequestClientHandler currently,
so we
    -			// have to notify credit available in CreditBasedClientHandler explicitly
    -			handler.notifyCreditAvailable(inputChannel);
    -
     			// Release the input channel
     			inputGate.releaseAllResources();
     
     			channel.runPendingTasks();
     
    -			// It will not notify credits for released input channel
    +			// It should send partition request first, and send close request after releasing
input channel,
    +			// but will not notify credits for released input channel.
    +			Object readFromOutbound = channel.readOutbound();
    +			assertThat(readFromOutbound, instanceOf(PartitionRequest.class));
    +			assertEquals(2, ((PartitionRequest) readFromOutbound).credit);
    +			readFromOutbound = channel.readOutbound();
    +			assertThat(readFromOutbound, instanceOf(CloseRequest.class));
    --- End diff --
    
    put these after `inputGate.releaseAllResources()`?


---

Mime
View raw message