flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #4117: [FLINK-6813][table]Add TIMESTAMPDIFF supported in ...
Date Mon, 15 Jan 2018 12:30:16 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4117#discussion_r161504809
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/calls/ScalarOperators.scala
---
    @@ -702,12 +703,15 @@ object ScalarOperators {
       def generateTemporalPlusMinus(
           plus: Boolean,
           nullCheck: Boolean,
    +      typeName: SqlTypeName,
           left: GeneratedExpression,
           right: GeneratedExpression)
         : GeneratedExpression = {
     
         val op = if (plus) "+" else "-"
     
    +    val AVGDAYS_PRE_MONTH = 30.5
    --- End diff --
    
    Is not a standard, I did not find the relevant norms, do you have any suggestions?


---

Mime
View raw message