flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...
Date Thu, 11 Jan 2018 15:11:15 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5225#discussion_r160985701
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -457,7 +499,19 @@ protected int stop(String[] args) throws Exception {
     
     		final CustomCommandLine<?> activeCommandLine = getActiveCustomCommandLine(commandLine);
     
    -		final ClusterClient client = activeCommandLine.retrieveCluster(commandLine, configuration,
configurationDirectory);
    +		final ClusterDescriptor<?> clusterDescriptor = activeCommandLine.createClusterDescriptor(
    --- End diff --
    
    You're right. I would like to postpone addressing this issue until we've introduce the
typed cluster id. Otherwise I fear that it would inflict quite some merge conflicts.


---

Mime
View raw message