flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery
Date Thu, 11 Jan 2018 14:26:20 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160948522
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/state/TestTaskStateManager.java
---
    @@ -0,0 +1,185 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + * http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.runtime.state;
    +
    +import org.apache.flink.api.common.JobID;
    +import org.apache.flink.core.testutils.OneShotLatch;
    +import org.apache.flink.runtime.checkpoint.CheckpointMetaData;
    +import org.apache.flink.runtime.checkpoint.CheckpointMetrics;
    +import org.apache.flink.runtime.checkpoint.OperatorSubtaskState;
    +import org.apache.flink.runtime.checkpoint.TaskStateSnapshot;
    +import org.apache.flink.runtime.executiongraph.ExecutionAttemptID;
    +import org.apache.flink.runtime.jobgraph.OperatorID;
    +import org.apache.flink.runtime.taskmanager.CheckpointResponder;
    +
    +import javax.annotation.Nonnull;
    +import javax.annotation.Nullable;
    +
    +import java.util.HashMap;
    +import java.util.Map;
    +
    +/**
    + * Implementation of {@link TaskStateManager} for tests.
    + */
    +public class TestTaskStateManager implements TaskStateManager {
    +
    +	private long reportedCheckpointId;
    +
    +	private JobID jobId;
    +	private ExecutionAttemptID executionAttemptID;
    +
    +	private final Map<Long, TaskStateSnapshot> taskStateSnapshotsByCheckpointId;
    +	private CheckpointResponder checkpointResponder;
    +	private OneShotLatch waitForReportLatch;
    +
    +	public TestTaskStateManager() {
    +		this(null, null, null);
    --- End diff --
    
    Does this constructor necessary have to have those nulls?  Can not those values be properly
initialised?
    
    By the way. Isn't this the symptom of a my previous remark that `TaskStateManager` should
be decomposed into two/three separate entities? 


---

Mime
View raw message