flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pnowojski <...@git.apache.org>
Subject [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery
Date Thu, 11 Jan 2018 14:26:20 GMT
Github user pnowojski commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160941763
  
    --- Diff: flink-runtime/src/test/java/org/apache/flink/runtime/taskexecutor/TaskExecutorTest.java
---
    @@ -210,10 +211,11 @@ public void testHeartbeatTimeoutWithJobManager() throws Exception
{
     			tmConfig,
     			taskManagerLocation,
     			mock(MemoryManager.class),
    -			mock(IOManager.class),
    +			mock(IOManager.class),mock(TaskExecutorLocalStateStoresManager.class),
    --- End diff --
    
    Can all of the `mock(TaskExecutorLocalStateStoresManager.class)` be replaced with: `new
TaskExecutorLocalStateStoresManager();` (with an empty array of for `localStateRootDirectories`)
or maybe `new TaskExecutorLocalStateStoresManager(sameThreadExecutor());`?


---

Mime
View raw message