flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From NicoK <...@git.apache.org>
Subject [GitHub] flink pull request #4552: [FLINK-7456][network] Implement Netty sender incom...
Date Wed, 10 Jan 2018 16:15:48 GMT
Github user NicoK commented on a diff in the pull request:

    https://github.com/apache/flink/pull/4552#discussion_r160695373
  
    --- Diff: flink-runtime/src/main/java/org/apache/flink/runtime/io/network/netty/PartitionRequestQueue.java
---
    @@ -98,20 +135,35 @@ public void close() {
     		}
     	}
     
    +	/**
    +	 * Adds to maintain the unannounced credits from the consumer and it may trigger
    +	 * enqueue the corresponding reader for this consumer transferring data.
    +	 *
    +	 * @param receiverId The input channel id to identify consumer.
    +	 * @param credit The unannounced credits of the consumer.
    +	 */
    +	public void addCredit(InputChannelID receiverId, int credit) throws Exception {
    --- End diff --
    
    could be `package-private`


---

Mime
View raw message