flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5220: [FLINK-8333] [flip6] Separate deployment options f...
Date Wed, 10 Jan 2018 15:34:59 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5220#discussion_r160711940
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/CliFrontend.java ---
    @@ -515,33 +464,28 @@ protected int stop(String[] args) {
     
     		if (stopArgs.length > 0) {
     			String jobIdString = stopArgs[0];
    -			try {
    -				jobId = new JobID(StringUtils.hexStringToByte(jobIdString));
    -			}
    -			catch (Exception e) {
    -				return handleError(e);
    -			}
    +			jobId = new JobID(StringUtils.hexStringToByte(jobIdString));
    --- End diff --
    
    Good point. Will throw a more meaningful exception.


---

Mime
View raw message