flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...
Date Wed, 10 Jan 2018 13:24:56 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5215#discussion_r160674931
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -717,7 +645,26 @@ public int run(
     				yarnCluster.waitForClusterToBeReady();
     				yarnCluster.disconnect();
     			} else {
    -				runInteractiveCli(yarnCluster, acceptInteractiveInput);
    +
    +				ScheduledThreadPoolExecutor scheduledExecutorService = new ScheduledThreadPoolExecutor(1);
    +
    +				try (YarnApplicationStatusMonitor yarnApplicationStatusMonitor = new YarnApplicationStatusMonitor(
    +						yarnDescriptor.getYarnClient(),
    +						yarnCluster.getApplicationId(),
    +						new ScheduledExecutorServiceAdapter(scheduledExecutorService))){
    +					runInteractiveCli(
    +						yarnCluster,
    +						yarnApplicationStatusMonitor,
    +						acceptInteractiveInput);
    +				} catch (Exception e) {
    +					LOG.info("Could not properly close the Yarn application status monitor.", e);
    --- End diff --
    
    Changed it.


---

Mime
View raw message