flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tillrohrmann <...@git.apache.org>
Subject [GitHub] flink pull request #5215: [FLINK-8328] [flip6] Move Yarn ApplicationStatus p...
Date Wed, 10 Jan 2018 13:21:23 GMT
Github user tillrohrmann commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5215#discussion_r160674117
  
    --- Diff: flink-yarn/src/main/java/org/apache/flink/yarn/cli/FlinkYarnSessionCli.java
---
    @@ -660,7 +570,25 @@ public int run(
     					"yarn application -kill " + applicationId.getOpt());
     				yarnCluster.disconnect();
     			} else {
    -				runInteractiveCli(yarnCluster, true);
    +				ScheduledThreadPoolExecutor scheduledExecutorService = new ScheduledThreadPoolExecutor(1);
    --- End diff --
    
    Yes it could be. That way, however, we support that we can use an arbitrary executor which
is available (as you've mentioned for tests). Since refactoring wouldn't add much value, I'll
keep it like this.


---

Mime
View raw message