flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Tue, 09 Jan 2018 14:35:14 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160421752
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
    @@ -278,7 +278,14 @@ class SetOperatorsITCase(
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    +  /**
    +    * This test will checks IN for NULLs based on whether COUNT (*) and COUNT (a) are
equal. Due to
    +    * [[org.apache.flink.table.plan.rules.dataSet.DataSetAggregateWithNullValuesRule]]
will
    +    * union a NULL row in to input DataSet for non-groupBy agg. That caused COUNT (*)
and COUNT(a)
    +    * are not equal. So this test case ignored before FLINK-8355 be fixed.
    --- End diff --
    
    I had a look at the test and think that it is correct.  `SELECT a FROM Table3` returns
`1, 2, 3` and `SELECT d FROM Table5` returns `1, 2, 2, 3, 3, 3, 4, 4, 4, 4, 5, 5, 5, 5, 5`.
So the result of the query should be 6 times `true` and 9 times `false`.
    
    Which result woud you expect?


---

Mime
View raw message