flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sunjincheng121 <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Tue, 09 Jan 2018 14:26:12 GMT
Github user sunjincheng121 commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160419117
  
    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
---
    @@ -278,7 +278,14 @@ class SetOperatorsITCase(
         TestBaseUtils.compareResultAsText(results.asJava, expected)
       }
     
    +  /**
    +    * This test will checks IN for NULLs based on whether COUNT (*) and COUNT (a) are
equal. Due to
    +    * [[org.apache.flink.table.plan.rules.dataSet.DataSetAggregateWithNullValuesRule]]
will
    +    * union a NULL row in to input DataSet for non-groupBy agg. That caused COUNT (*)
and COUNT(a)
    +    * are not equal. So this test case ignored before FLINK-8355 be fixed.
    --- End diff --
    
    A workaround way is we create a `transformToBatchAggregateFunctions` or add a parameter
to `transformToAggregateFunctions` which can identify batch or stream.
    but not elegant :(.


---

Mime
View raw message