flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Mon, 08 Jan 2018 22:26:15 GMT
Github user fhueske commented on a diff in the pull request:

    --- Diff: flink-libraries/flink-table/src/test/scala/org/apache/flink/table/runtime/batch/sql/SetOperatorsITCase.scala
    @@ -278,7 +278,14 @@ class SetOperatorsITCase(
         TestBaseUtils.compareResultAsText(results.asJava, expected)
    +  /**
    +    * This test will checks IN for NULLs based on whether COUNT (*) and COUNT (a) are
equal. Due to
    +    * [[org.apache.flink.table.plan.rules.dataSet.DataSetAggregateWithNullValuesRule]]
    +    * union a NULL row in to input DataSet for non-groupBy agg. That caused COUNT (*)
and COUNT(a)
    +    * are not equal. So this test case ignored before FLINK-8355 be fixed.
    --- End diff --
    This PR introduces a regression. Previously working queries will compute incorrect results
when we merge it. 
    IMO, we should only merge it if all existing tests pass. The problem is that FLINK-8355
cannot be easily fixed. We need to add a NULL tuple, because Flink's DataSet API won't compute
any result if the input is empty. Not sure how this can be resolved.


View raw message