flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From fhueske <...@git.apache.org>
Subject [GitHub] flink pull request #5241: [FLINK-8325][table] Add COUNT(*),COUNT(1) supporte...
Date Mon, 08 Jan 2018 22:26:13 GMT
Github user fhueske commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5241#discussion_r160253551
  
    --- Diff: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/codegen/AggregationCodeGenerator.scala
---
    @@ -383,12 +388,16 @@ class AggregationCodeGenerator(
     
           val retract: String = {
             for (i <- aggs.indices) yield {
    -          j"""
    -             |    ${accTypes(i)} acc$i = (${accTypes(i)}) accs.getField($i);
    -             |    ${genDataViewFieldSetter(s"acc$i", i)}
    -             |    ${aggs(i)}.retract(
    -             |      acc$i,
    -             |      ${parametersCode(i)});""".stripMargin
    --- End diff --
    
    same as for accumulate


---

Mime
View raw message