flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StefanRRichter <...@git.apache.org>
Subject [GitHub] flink pull request #5239: [FLINK-8360] Implement task-local state recovery
Date Mon, 08 Jan 2018 09:45:08 GMT
Github user StefanRRichter commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5239#discussion_r160102220
  
    --- Diff: flink-contrib/flink-storm/src/test/java/org/apache/flink/storm/wrappers/BoltWrapperTest.java
---
    @@ -375,11 +376,13 @@ public void declareOutputFields(OutputFieldsDeclarer declarer) {
     		when(env.getMetricGroup()).thenReturn(new UnregisteredTaskMetricsGroup());
     		when(env.getTaskManagerInfo()).thenReturn(new TestingTaskManagerRuntimeInfo());
     
    +		final CloseableRegistry closeableRegistry = new CloseableRegistry();
     		StreamTask<?, ?> mockTask = mock(StreamTask.class);
     		when(mockTask.getCheckpointLock()).thenReturn(new Object());
     		when(mockTask.getConfiguration()).thenReturn(new StreamConfig(new Configuration()));
     		when(mockTask.getEnvironment()).thenReturn(env);
     		when(mockTask.getExecutionConfig()).thenReturn(execConfig);
    +		when(mockTask.getCancelables()).thenReturn(closeableRegistry);
    --- End diff --
    
    I completely share your dislike of Mockito. Overall this PR has already a lot of changes
and I suggest to address those orthogonal test changes that remove Mockito in a separate task
and PR.


---

Mime
View raw message