flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GJL <...@git.apache.org>
Subject [GitHub] flink pull request #5225: [FLINK-8339] [flip6] Let CustomCommandLine return ...
Date Fri, 05 Jan 2018 14:20:42 GMT
Github user GJL commented on a diff in the pull request:

    https://github.com/apache/flink/pull/5225#discussion_r159885568
  
    --- Diff: flink-clients/src/main/java/org/apache/flink/client/cli/AbstractCustomCommandLine.java
---
    @@ -0,0 +1,84 @@
    +/*
    + * Licensed to the Apache Software Foundation (ASF) under one
    + * or more contributor license agreements.  See the NOTICE file
    + * distributed with this work for additional information
    + * regarding copyright ownership.  The ASF licenses this file
    + * to you under the Apache License, Version 2.0 (the
    + * "License"); you may not use this file except in compliance
    + * with the License.  You may obtain a copy of the License at
    + *
    + *     http://www.apache.org/licenses/LICENSE-2.0
    + *
    + * Unless required by applicable law or agreed to in writing, software
    + * distributed under the License is distributed on an "AS IS" BASIS,
    + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
    + * See the License for the specific language governing permissions and
    + * limitations under the License.
    + */
    +
    +package org.apache.flink.client.cli;
    +
    +import org.apache.flink.client.ClientUtils;
    +import org.apache.flink.client.program.ClusterClient;
    +import org.apache.flink.configuration.Configuration;
    +import org.apache.flink.configuration.HighAvailabilityOptions;
    +
    +import org.apache.commons.cli.CommandLine;
    +import org.apache.commons.cli.Option;
    +import org.apache.commons.cli.Options;
    +
    +import java.net.InetSocketAddress;
    +
    +import static org.apache.flink.client.cli.CliFrontend.setJobManagerAddressInConfig;
    +
    +/**
    + * Base class for {@link CustomCommandLine} implementations which specify a JobManager
address and
    + * a ZooKeeper namespace.
    + *
    + * @param <C> type of the ClusterClient which is returned
    + */
    +public abstract class AbstractCustomCommandLine<C extends ClusterClient> implements
CustomCommandLine<C> {
    +
    +	protected static final Option ZOOKEEPER_NAMESPACE_OPTION = new Option("z", "zookeeperNamespace",
true,
    +		"Namespace to create the Zookeeper sub-paths for high availability mode");
    +
    +
    +	protected static final Option ADDRESS_OPTION = new Option("m", "jobmanager", true,
    --- End diff --
    
    Why are the options here constants? In `FlinkYarnSessionCli` the `Option`s are instance
variables. Also `Option`s are mutable.


---

Mime
View raw message