flink-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From StephanEwen <...@git.apache.org>
Subject [GitHub] flink issue #5243: [FLINK-8362][elasticsearch] shade all dependencies
Date Fri, 05 Jan 2018 13:49:59 GMT
Github user StephanEwen commented on the issue:

    https://github.com/apache/flink/pull/5243
  
    I vaguely recall that there was a reason why we did not shade the Elasticsearch connectors
initially. Maybe a license issue. @zentol and @tzulitai can you chime in here?
    
    If we want to go ahead with this, few comments:
      - Not sure we should relocate the Flink elasticsearch code. Why is that needed?
      - Would be good to add for each dependency that is shaded should have a comment about
the license. Some licenses are not compatible with shading.
      - Some licenses may need an additional license file or a mention in an extra bundled
NOTICE file, see the `flink-s3-fs-presto`
      - In general, we cannot suppress all forwarded files from `META-INF` for dependencies,
especiallylicense related files.


---

Mime
View raw message